Feat: Dynamic import refinements & fixes, optimization #102
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades dynamic import analysis, as described in the readme diff here, and fixes #56, #53 and #98.
To summarize the changes:
d
no longer tracks the start of the dynamic import statementimport('x')
but rather the start of the bracket at('x')
ss
tose
range can be reliably used for the whole statementimport('x')
s
ande
range will either be the inside of the brackets for an unknown expression, or the exact quoted string start and end position after whitespace and comments but including the quotes for a string literal import.This also includes a bugfix for the asm.js build with multiline dynamic imports.
Since this is a breaking change it will be the 0.10 release.
It also includes some hard-won optimization work bringing the footprints from:
to: